From 9ae0e585b0aab466c978ec1a55c824d902faa3b4 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Mon, 21 Apr 2014 16:47:16 +1000 Subject: View2d: API Cleanup for view<->region conversion View2D had some inconsistencies making it error prone in some cases. - Inconstant checking for NULL x/y args. Disallow NULL args for x/y destination pointers, instead add: - UI_view2d_region_to_view_x/y - UI_view2d_view_to_region_x/y - '_no_clip' suffix wasn't always used for non-clipping conversion, switch it around and use a '_clip' suffix for all funcs that clip. - UI_view2d_text_cache_add now clips before adding cache. - '_clip' funcs return a bool to quickly check if its in the view. - add conversion for rectangles, since this is a common task: - UI_view2d_view_to_region_rcti - UI_view2d_region_to_view_rctf --- source/blender/editors/space_info/info_report.c | 9 --------- 1 file changed, 9 deletions(-) (limited to 'source/blender/editors/space_info/info_report.c') diff --git a/source/blender/editors/space_info/info_report.c b/source/blender/editors/space_info/info_report.c index 2135166abe9..7dc46d51ca0 100644 --- a/source/blender/editors/space_info/info_report.c +++ b/source/blender/editors/space_info/info_report.c @@ -236,15 +236,6 @@ static int borderselect_exec(bContext *C, wmOperator *op) WM_operator_properties_border_to_rcti(op, &rect); -#if 0 - mval[0] = rect.xmin; - mval[1] = rect.ymin; - UI_view2d_region_to_view(v2d, mval[0], mval[1], &rectf.xmin, &rectf.ymin); - mval[0] = rect.xmax; - mval[1] = rect.ymax; - UI_view2d_region_to_view(v2d, mval[0], mval[1], &rectf.xmax, &rectf.ymax); -#endif - if (!extend) { for (report = reports->list.first; report; report = report->next) { -- cgit v1.2.3