From 8522b429b56838e343c5cbe8889dcbf792e23a38 Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Tue, 9 Jun 2020 12:17:00 +0200 Subject: Transform: Fixes after recent refactor Pointed by strict compiler warnings, but some of the reports were actually a real bugs: - Access uninitialized memory of td_mirror_iter. Assuming that iterator is to point to the first element of the data array. - Lattice's recalc data was never called. There is also a fix for redundant declaration of recalcData() and missing declaration of recalcData_lattice(). --- source/blender/editors/transform/transform_convert_mesh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source/blender/editors/transform/transform_convert_mesh.c') diff --git a/source/blender/editors/transform/transform_convert_mesh.c b/source/blender/editors/transform/transform_convert_mesh.c index 6bee3760f4d..710ddf60176 100644 --- a/source/blender/editors/transform/transform_convert_mesh.c +++ b/source/blender/editors/transform/transform_convert_mesh.c @@ -535,7 +535,7 @@ static TransDataMirror *editmesh_mirror_data_calc(BMEditMesh *em, TransDataMirror *td_mirror_iter, *td_mirror = NULL; if (mirror_elem_len != 0) { td_mirror = MEM_mallocN(mirror_elem_len * sizeof(*td_mirror), __func__); - td_mirror_iter = &td_mirror_iter[0]; + td_mirror_iter = &td_mirror[0]; *r_mirror_bitmap = BLI_BITMAP_NEW(bm->totvert, __func__); -- cgit v1.2.3