From ad6e63cb96a497721d7ad6aeb5cf119d3264036c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Fri, 7 Aug 2020 17:59:12 +0200 Subject: Cleanup: enable Clang-Tidy `bugprone-parent-virtual-call` rule I added a single `NOLINT` exception with explanation. No functional changes. --- source/blender/freestyle/intern/scene_graph/OrientedLineRep.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'source/blender/freestyle/intern') diff --git a/source/blender/freestyle/intern/scene_graph/OrientedLineRep.cpp b/source/blender/freestyle/intern/scene_graph/OrientedLineRep.cpp index 9e83527acad..e8e21d37d00 100644 --- a/source/blender/freestyle/intern/scene_graph/OrientedLineRep.cpp +++ b/source/blender/freestyle/intern/scene_graph/OrientedLineRep.cpp @@ -27,7 +27,9 @@ namespace Freestyle { void OrientedLineRep::accept(SceneVisitor &v) { - Rep::accept(v); + Rep::accept(v); // NOLINT(bugprone-parent-virtual-call), this seems to intentionally *not* call + // the parent class' accept() function, but rather the grandparent's. The + // v.visitLineRep(*this); call below is actually what the parent class would do. if (!frs_material()) { v.visitOrientedLineRep(*this); } -- cgit v1.2.3