From 1ef8ef4941dd84c8968109b5c858ed8d082d9187 Mon Sep 17 00:00:00 2001 From: Richard Antalik Date: Wed, 1 Dec 2021 12:30:57 +0100 Subject: Cleanup: Remove seq->tmp_flag DNA member Commit f0d20198b290 used this field to flag rendered strips which were queried by `SEQ_query_rendered_strips()`. Then operators iterate all strips and checks state of `seq->tmp_flag`. Use collection returned by `SEQ_query_rendered_strips` directly. There should be no functional changes. This commit adds functions `all_strips_from_context` and `selected_strips_from_context` that provide collection of strips based on context. Most operators can use this collection directly. There is already `seq->tmp` DNA field, but is should not be used unless absolutely necessary. Better option is to use human readable flag. Best is to not use DNA fields for temporary storage in runtime. --- source/blender/makesdna/DNA_sequence_types.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'source/blender/makesdna') diff --git a/source/blender/makesdna/DNA_sequence_types.h b/source/blender/makesdna/DNA_sequence_types.h index 9e6cf907444..e1bba60396a 100644 --- a/source/blender/makesdna/DNA_sequence_types.h +++ b/source/blender/makesdna/DNA_sequence_types.h @@ -180,8 +180,7 @@ typedef struct Sequence { int startdisp, enddisp; float sat; float mul; - char tmp_tag; - char _pad[3]; + float _pad; short anim_preseek; /* UNUSED. */ /** Streamindex for movie or sound files with several streams. */ -- cgit v1.2.3