From e845467d93fe35e222d14b0bb27472ccb309b321 Mon Sep 17 00:00:00 2001 From: Hans Goudey Date: Fri, 22 Jan 2021 11:08:58 -0600 Subject: Fix: Mouse presses in some areas do not set active modifier There are a couple of operations that are meant to set the active modifier that currently don't. The first is a mouse press on the drag icon on the right of the header, and the second is mouse presses on modifier sub-panels headers. This was an oversight in the implementation, especially the second, because the blank space on the right of a sub-panel header often looks just like the blank space elsewhere on the modifier's panel that *does* set the active modifier. Note that this purposefully doesn't include collapsing and expanding the modifier as operations that set the active, since regardless of whether that makes sense, it wasn't in the agreed upon design, which would ideally not need changing for 2.92. Differential Revision: https://developer.blender.org/D10155 --- source/blender/modifiers/intern/MOD_ui_common.c | 1 + 1 file changed, 1 insertion(+) (limited to 'source/blender/modifiers') diff --git a/source/blender/modifiers/intern/MOD_ui_common.c b/source/blender/modifiers/intern/MOD_ui_common.c index c5ee96491b8..821c74496f2 100644 --- a/source/blender/modifiers/intern/MOD_ui_common.c +++ b/source/blender/modifiers/intern/MOD_ui_common.c @@ -460,6 +460,7 @@ PanelType *modifier_subpanel_register(ARegionType *region_type, BLI_strncpy(panel_type->label, label, BKE_ST_MAXNAME); BLI_strncpy(panel_type->context, "modifier", BKE_ST_MAXNAME); BLI_strncpy(panel_type->translation_context, BLT_I18NCONTEXT_DEFAULT_BPYRNA, BKE_ST_MAXNAME); + BLI_strncpy(panel_type->active_property, "is_active", BKE_ST_MAXNAME); panel_type->draw_header = draw_header; panel_type->draw = draw; -- cgit v1.2.3