From 5583d517730f4c7ad487c099df0394700a246675 Mon Sep 17 00:00:00 2001 From: Philipp Oeser Date: Wed, 14 Jul 2021 11:39:38 +0200 Subject: Fix T89851: Geometry nodes: wrongly detected "Node group has unidentified nodes or sockets" error rBfe22635bf664 introduced a utility to check for this (but it was always returning true). This wasnt a problem in master (since it is unused there), but in the 2.93 branch, this utility is actually used and the error results in all geometry nodetrees to appear with the "Node group has unidentified nodes or sockets" message (and being unusable). Now return false in has_undefined_nodes_or_sockets if all nodes and sockets have been successfully checked. This commit then needs to end up in the 2.93 branch. Maniphest Tasks: T89851 Differential Revision: https://developer.blender.org/D11911 --- source/blender/nodes/intern/node_tree_ref.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source/blender/nodes/intern') diff --git a/source/blender/nodes/intern/node_tree_ref.cc b/source/blender/nodes/intern/node_tree_ref.cc index bed4d60382d..9ce9d6fc273 100644 --- a/source/blender/nodes/intern/node_tree_ref.cc +++ b/source/blender/nodes/intern/node_tree_ref.cc @@ -461,7 +461,7 @@ bool NodeTreeRef::has_undefined_nodes_or_sockets() const return true; } } - return true; + return false; } std::string NodeTreeRef::to_dot() const -- cgit v1.2.3