From 48c5129d1fcdaf53a281bf0359af85bd0185f038 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Thu, 22 Apr 2021 12:34:26 +1000 Subject: Fix errors in Buffer.dimensions `setter` - Error accessing the length from a sequence. - Error comparing a boolean to -1. Issues introduced in 19360c2c1cf50c80b9720137b88db2c2f3626ddc --- source/blender/python/gpu/gpu_py_buffer.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'source/blender/python') diff --git a/source/blender/python/gpu/gpu_py_buffer.c b/source/blender/python/gpu/gpu_py_buffer.c index 8ee11ff882c..e36e3b42617 100644 --- a/source/blender/python/gpu/gpu_py_buffer.c +++ b/source/blender/python/gpu/gpu_py_buffer.c @@ -81,7 +81,7 @@ static bool pygpu_buffer_pyobj_as_shape(PyObject *shape_obj, } } else if (PySequence_Check(shape_obj)) { - Py_ssize_t shape_len = PySequence_Size(shape_obj); + shape_len = PySequence_Size(shape_obj); if (shape_len > MAX_DIMENSIONS) { PyErr_SetString(PyExc_AttributeError, "too many dimensions, max is " STRINGIFY(MAX_DIMENSIONS)); @@ -111,8 +111,6 @@ static bool pygpu_buffer_pyobj_as_shape(PyObject *shape_obj, return false; } } - - *r_shape_len = shape_len; } else { PyErr_Format(PyExc_TypeError, @@ -398,7 +396,7 @@ static PyObject *pygpu_buffer__tp_new(PyTypeObject *UNUSED(type), PyObject *args return NULL; } - if (pygpu_buffer_pyobj_as_shape(length_ob, shape, &shape_len) == -1) { + if (!pygpu_buffer_pyobj_as_shape(length_ob, shape, &shape_len)) { return NULL; } -- cgit v1.2.3