From e60bc528f0f936d64abdc261df961f60e919facb Mon Sep 17 00:00:00 2001 From: Jeroen Bakker Date: Wed, 21 Oct 2020 08:09:52 +0200 Subject: DrawManager: Adding Custom Render Passes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently render passes in the draw manager (eevee) must be predefined in the render result. This patch would ask the render engine for the render passes it needs, and create these as a preparation step during rendering. This allows any draw engine to define more complex render passes setup. Render passes can only be added before the call to `RE_engine_begin_result`. `RE_engine_begin_result` makes a full copy of the render passes. During rendering the render engines renders to the duplicated passes. `RE_engine_end_result` syncs the data back to the original render passes, but only if the passes existed in the original render result. Currently we work-around this issue by registering the passes in `render_result_new`. This is legacy blender internal structure and should be avoided. With upcoming projects (AOV/Cryptomatte) it becomes a bit of a mess as we are extending legacy code to support new features. This patch allows us to let each draw engine register their own render passes at render time (similar to cycles and other render engines). In the future we could get rid of legacy render passes registration in render_result_new. Reviewed By: Clément Foucault Differential Revision: https://developer.blender.org/D9088 --- source/blender/render/intern/source/render_result.c | 9 --------- 1 file changed, 9 deletions(-) (limited to 'source/blender/render') diff --git a/source/blender/render/intern/source/render_result.c b/source/blender/render/intern/source/render_result.c index d2f21ab035c..db75cb5cfed 100644 --- a/source/blender/render/intern/source/render_result.c +++ b/source/blender/render/intern/source/render_result.c @@ -444,15 +444,6 @@ RenderResult *render_result_new(Render *re, if (view_layer->passflag & SCE_PASS_SUBSURFACE_COLOR) { RENDER_LAYER_ADD_PASS_SAFE(rr, rl, 3, RE_PASSNAME_SUBSURFACE_COLOR, view, "RGB"); } - if (view_layer->eevee.render_passes & EEVEE_RENDER_PASS_BLOOM) { - RENDER_LAYER_ADD_PASS_SAFE(rr, rl, 3, RE_PASSNAME_BLOOM, view, "RGB"); - } - if (view_layer->eevee.render_passes & EEVEE_RENDER_PASS_VOLUME_SCATTER) { - RENDER_LAYER_ADD_PASS_SAFE(rr, rl, 3, RE_PASSNAME_VOLUME_SCATTER, view, "RGB"); - } - if (view_layer->eevee.render_passes & EEVEE_RENDER_PASS_VOLUME_TRANSMITTANCE) { - RENDER_LAYER_ADD_PASS_SAFE(rr, rl, 3, RE_PASSNAME_VOLUME_TRANSMITTANCE, view, "RGB"); - } #undef RENDER_LAYER_ADD_PASS_SAFE } } -- cgit v1.2.3