From 5a4045ad7dbb2cd2fe738b8999309d643b3a3ead Mon Sep 17 00:00:00 2001 From: Damien Plisson Date: Wed, 18 Nov 2009 16:38:22 +0000 Subject: Quicktime (non cocoa) crash upon export temporary fix Removed the pop up of the codec settings dialog box that was causing the crash, as it was called from the render thread (and not the main one). So qt export settings are now blocked on default settings: codec=jpeg, quality=max, bitrate=5MBps Complete fix will be done by replacing this dialog box by "encoding" settings in the render panel. --- source/blender/quicktime/apple/quicktime_export.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'source/blender') diff --git a/source/blender/quicktime/apple/quicktime_export.c b/source/blender/quicktime/apple/quicktime_export.c index a2727963032..bec26bbb207 100644 --- a/source/blender/quicktime/apple/quicktime_export.c +++ b/source/blender/quicktime/apple/quicktime_export.c @@ -620,12 +620,13 @@ int get_qtcodec_settings(RenderData *rd) check_renderbutton_framerate(rd); } else { // configure the standard image compression dialog box - // set some default settings + // set some default settings: codec=jpeg, quality = max + qtdata->gSpatialSettings.codecType = kJPEGCodecType; qtdata->gSpatialSettings.codec = anyCodec; qtdata->gSpatialSettings.spatialQuality = codecMaxQuality; qtdata->gTemporalSettings.temporalQuality = codecMaxQuality; qtdata->gTemporalSettings.keyFrameRate = 25; - qtdata->aDataRateSetting.dataRate = 90 * 1024; + qtdata->aDataRateSetting.dataRate = 5 * 1024 * 1024; err = SCSetInfo(qtdata->theComponent, scTemporalSettingsType, &qtdata->gTemporalSettings); CheckError(err, "SCSetInfo1 error"); @@ -637,6 +638,8 @@ int get_qtcodec_settings(RenderData *rd) check_renderbutton_framerate(rd); + /* Remove this dialog box pop up as this function is called from the render thread + Anyway, all config should be done inside blender ui before starting render. // put up the dialog box - it needs to be called from the main thread err = SCRequestSequenceSettings(qtdata->theComponent); @@ -648,7 +651,7 @@ int get_qtcodec_settings(RenderData *rd) // get user selected data SCGetInfo(qtdata->theComponent, scTemporalSettingsType, &qtdata->gTemporalSettings); SCGetInfo(qtdata->theComponent, scSpatialSettingsType, &qtdata->gSpatialSettings); - SCGetInfo(qtdata->theComponent, scDataRateSettingsType, &qtdata->aDataRateSetting); + SCGetInfo(qtdata->theComponent, scDataRateSettingsType, &qtdata->aDataRateSetting);*/ QT_SaveCodecSettingsToScene(rd); -- cgit v1.2.3