From b01f2607a6717deafc96c07287202ab11c118737 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Thu, 3 Jan 2019 15:13:46 +1100 Subject: Transform: default shrink/fatten even-offset to false Changed for 2.8 but this cases spikes for some geometry, see: T59968 --- source/blender/editors/transform/transform.c | 6 +++--- source/blender/editors/transform/transform_generics.c | 2 +- source/blender/editors/transform/transform_ops.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'source/blender') diff --git a/source/blender/editors/transform/transform.c b/source/blender/editors/transform/transform.c index 7509b88ccff..f7a27571b64 100644 --- a/source/blender/editors/transform/transform.c +++ b/source/blender/editors/transform/transform.c @@ -2223,7 +2223,7 @@ void saveTransform(bContext *C, TransInfo *t, wmOperator *op) } if (prop_id && (prop = RNA_struct_find_property(op->ptr, prop_id))) { - RNA_property_boolean_set(op->ptr, prop, ((t->flag & T_ALT_TRANSFORM) != 0) == prop_state); + RNA_property_boolean_set(op->ptr, prop, ((t->flag & T_ALT_TRANSFORM) == 0) == prop_state); } } @@ -5050,7 +5050,7 @@ static void applyShrinkFatten(TransInfo *t, const int UNUSED(mval[2])) } } BLI_snprintf(str + ofs, sizeof(str) - ofs, IFACE_(" or Alt) Even Thickness %s"), - WM_bool_as_string((t->flag & T_ALT_TRANSFORM) == 0)); + WM_bool_as_string((t->flag & T_ALT_TRANSFORM) != 0)); /* done with header string */ FOREACH_TRANS_DATA_CONTAINER (t, tc) { @@ -5065,7 +5065,7 @@ static void applyShrinkFatten(TransInfo *t, const int UNUSED(mval[2])) /* get the final offset */ tdistance = distance * td->factor; - if (td->ext && (t->flag & T_ALT_TRANSFORM) == 0) { + if (td->ext && (t->flag & T_ALT_TRANSFORM) != 0) { tdistance *= td->ext->isize[0]; /* shell factor */ } diff --git a/source/blender/editors/transform/transform_generics.c b/source/blender/editors/transform/transform_generics.c index 11931160fca..882ef9e7301 100644 --- a/source/blender/editors/transform/transform_generics.c +++ b/source/blender/editors/transform/transform_generics.c @@ -1374,7 +1374,7 @@ void initTransInfo(bContext *C, TransInfo *t, wmOperator *op, const wmEvent *eve } if (prop_id && (prop = RNA_struct_find_property(op->ptr, prop_id))) { - SET_FLAG_FROM_TEST(t->flag, !RNA_property_boolean_get(op->ptr, prop), T_ALT_TRANSFORM); + SET_FLAG_FROM_TEST(t->flag, RNA_property_boolean_get(op->ptr, prop), T_ALT_TRANSFORM); } } diff --git a/source/blender/editors/transform/transform_ops.c b/source/blender/editors/transform/transform_ops.c index 5a3575c04d9..6bef5e4671a 100644 --- a/source/blender/editors/transform/transform_ops.c +++ b/source/blender/editors/transform/transform_ops.c @@ -896,7 +896,7 @@ static void TRANSFORM_OT_shrink_fatten(struct wmOperatorType *ot) RNA_def_float(ot->srna, "value", 0, -FLT_MAX, FLT_MAX, "Offset", "", -FLT_MAX, FLT_MAX); - RNA_def_boolean(ot->srna, "use_even_offset", true, "Offset Even", "Scale the offset to give more even thickness"); + RNA_def_boolean(ot->srna, "use_even_offset", false, "Offset Even", "Scale the offset to give more even thickness"); WM_operatortype_props_advanced_begin(ot); -- cgit v1.2.3