From 240148f36346bbcf5476799c27e9775fe3766597 Mon Sep 17 00:00:00 2001 From: Joshua Leung Date: Thu, 31 Jan 2008 22:47:03 +0000 Subject: Action Editor Bugs/Regressions: * Insert Key and Column Select should be working again * Last channel in group's keyframes now appear in summary too --- source/blender/src/drawaction.c | 2 +- source/blender/src/editaction.c | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) (limited to 'source') diff --git a/source/blender/src/drawaction.c b/source/blender/src/drawaction.c index aac13231c50..ea1a17f0b69 100644 --- a/source/blender/src/drawaction.c +++ b/source/blender/src/drawaction.c @@ -1419,7 +1419,7 @@ void agroup_to_keylist(bActionGroup *agrp, ListBase *keys, ListBase *blocks, Act if (agrp) { /* loop through action channels */ - for (achan= agrp->channels.first; achan && achan!=agrp->channels.last; achan= achan->next) { + for (achan= agrp->channels.first; achan && achan->grp==agrp; achan= achan->next) { /* firstly, add keys from action channel's ipo block */ if (achan->ipo) ipo_to_keylist(achan->ipo, keys, blocks, aki); diff --git a/source/blender/src/editaction.c b/source/blender/src/editaction.c index 8dc16909193..0d48db79b8f 100644 --- a/source/blender/src/editaction.c +++ b/source/blender/src/editaction.c @@ -326,9 +326,13 @@ static void actdata_filter_actionchannel (ListBase *act_data, bActionChannel *ac if (ale) BLI_addtail(act_data, ale); } } + else { + /* for insert key... this check could be improved */ + return; + } /* check if expanded - if not, continue on to next action channel */ - if (EXPANDED_ACHAN(achan) == 0) + if (EXPANDED_ACHAN(achan) == 0 && (filter_mode & ACTFILTER_ONLYICU)==0) return; /* ipo channels */ @@ -360,7 +364,7 @@ static void actdata_filter_actionchannel (ListBase *act_data, bActionChannel *ac } /* add constraint channels? */ - if (FILTER_CON_ACHAN(achan)) { + if (FILTER_CON_ACHAN(achan) || (filter_mode & ACTFILTER_ONLYICU)) { /* loop through constraint channels, checking and adding them */ for (conchan=achan->constraintChannels.first; conchan; conchan=conchan->next) { /* only work with this channel and its subchannels if it is editable */ -- cgit v1.2.3