From 42d0107ee5802d3e473c7af8880021078e6d13e3 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Wed, 3 Nov 2021 22:12:42 +1100 Subject: Fix crash dissolving overlapping faces In rare cases disolving faces would crash, caused by iterator variable reuse in b29a8a5dfe3d6eb2fbbdecd0d5dffb3d709b9b91. --- source/blender/bmesh/operators/bmo_dissolve.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'source') diff --git a/source/blender/bmesh/operators/bmo_dissolve.c b/source/blender/bmesh/operators/bmo_dissolve.c index efba0ec99ec..360dcc2c79e 100644 --- a/source/blender/bmesh/operators/bmo_dissolve.c +++ b/source/blender/bmesh/operators/bmo_dissolve.c @@ -233,8 +233,8 @@ void bmo_dissolve_faces_exec(BMesh *bm, BMOperator *op) * This could optionally do a partial merge, where some faces are joined. */ /* Prevent these faces from being removed. */ - for (i = 0; i < faces_len; i++) { - BMO_face_flag_disable(bm, faces[i], FACE_ORIG); + for (int j = 0; j < faces_len; j++) { + BMO_face_flag_disable(bm, faces[j], FACE_ORIG); } } } -- cgit v1.2.3