diff options
author | Denis Vlasenko <vda.linux@googlemail.com> | 2008-03-17 12:07:36 +0300 |
---|---|---|
committer | Denis Vlasenko <vda.linux@googlemail.com> | 2008-03-17 12:07:36 +0300 |
commit | 62a90cdd7435f09f4bb8673e8b7b213067f9d5cc (patch) | |
tree | ac7f86c4de0ce0c095b59820c7ba238369c65f71 /editors | |
parent | d02db892440499a072ea8c83c2370e9d9c103098 (diff) |
*: shrink by using [f]open_or_warn_stdin where appropriate
function old new delta
lsattr_main 62 143 +81
open_or_warn_stdin - 36 +36
fclose_if_not_stdin 20 47 +27
xfopen_stdin - 20 +20
tac_main 336 356 +20
cksum_main 249 259 +10
bb_argv_dash - 8 +8
su_main 448 455 +7
cmp_main 630 633 +3
passwd_main 1072 1074 +2
uudecode_main 317 315 -2
text_yank 110 108 -2
handle_incoming_and_exit 2653 2651 -2
flags 5 1 -4
write_leases 235 230 -5
fopen_or_warn_stdin 48 42 -6
fold_main 648 642 -6
static.argv_dash 8 - -8
sum_main 142 128 -14
tail_main 1237 1221 -16
sed_main 711 695 -16
cmp_xfopen_input 17 - -17
bb_cat 113 96 -17
catv_main 328 306 -22
strings_main 457 434 -23
hash_file 298 274 -24
sum_file 353 325 -28
sort_main 904 859 -45
expand_main 736 686 -50
cut_main 1116 1065 -51
md5_sha1_sum_main 549 493 -56
lsattr_args 90 - -90
read_stduu 408 255 -153
------------------------------------------------------------------------------
(add/remove: 3/3 grow/shrink: 7/20 up/down: 214/-657) Total: -443 bytes
text data bss dec hex filename
797417 658 7428 805503 c4a7f busybox_old
796973 658 7428 805059 c48c3 busybox_unstripped
Diffstat (limited to 'editors')
-rw-r--r-- | editors/cmp.c | 14 | ||||
-rw-r--r-- | editors/sed.c | 11 |
2 files changed, 7 insertions, 18 deletions
diff --git a/editors/cmp.c b/editors/cmp.c index 9189b3150..b211adf9f 100644 --- a/editors/cmp.c +++ b/editors/cmp.c @@ -23,16 +23,6 @@ #include "libbb.h" -static FILE *cmp_xfopen_input(const char *filename) -{ - FILE *fp; - - fp = fopen_or_warn_stdin(filename); - if (fp) - return fp; - xfunc_die(); /* We already output an error message. */ -} - static const char fmt_eof[] ALIGN1 = "cmp: EOF on %s\n"; static const char fmt_differ[] ALIGN1 = "%s %s differ: char %"OFF_FMT"d, line %d\n"; // This fmt_l_opt uses gnu-isms. SUSv3 would be "%.0s%.0s%"OFF_FMT"d %o %o\n" @@ -65,7 +55,7 @@ int cmp_main(int argc ATTRIBUTE_UNUSED, char **argv) argv += optind; filename1 = *argv; - fp1 = cmp_xfopen_input(filename1); + fp1 = xfopen_stdin(filename1); if (*++argv) { filename2 = *argv; @@ -79,7 +69,7 @@ int cmp_main(int argc ATTRIBUTE_UNUSED, char **argv) #endif } - fp2 = cmp_xfopen_input(filename2); + fp2 = xfopen_stdin(filename2); if (fp1 == fp2) { /* Paranoia check... stdin == stdin? */ /* Note that we don't bother reading stdin. Neither does gnu wc. * But perhaps we should, so that other apps down the chain don't diff --git a/editors/sed.c b/editors/sed.c index a0994aec0..32911f8f9 100644 --- a/editors/sed.c +++ b/editors/sed.c @@ -1231,7 +1231,7 @@ static void add_cmd_block(char *cmdstr) } int sed_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; -int sed_main(int argc, char **argv) +int sed_main(int argc ATTRIBUTE_UNUSED, char **argv) { enum { OPT_in_place = 1 << 0, @@ -1246,7 +1246,7 @@ int sed_main(int argc, char **argv) if (ENABLE_FEATURE_CLEAN_UP) atexit(sed_free_and_close_stuff); /* Lie to autoconf when it starts asking stupid questions. */ - if (argc == 2 && !strcmp(argv[1], "--version")) { + if (argv[1] && !strcmp(argv[1], "--version")) { puts("This is not GNU sed version 4.0"); return 0; } @@ -1257,7 +1257,7 @@ int sed_main(int argc, char **argv) "nn"; /* count -n */ opt = getopt32(argv, "irne:f:", &opt_e, &opt_f, &G.be_quiet); /* counter for -n */ - argc -= optind; + //argc -= optind; argv += optind; if (opt & OPT_in_place) { // -i atexit(cleanup_outname); @@ -1283,10 +1283,9 @@ int sed_main(int argc, char **argv) } /* if we didn't get a pattern from -e or -f, use argv[0] */ if (!(opt & 0x18)) { - if (!argc) + if (!*argv) bb_show_usage(); add_cmd_block(*argv++); - argc--; } /* Flush any unfinished commands. */ add_cmd(""); @@ -1306,7 +1305,7 @@ int sed_main(int argc, char **argv) int i; FILE *file; - for (i = 0; i < argc; i++) { + for (i = 0; argv[i]; i++) { struct stat statbuf; int nonstdoutfd; |