diff options
author | Shawn O. Pearce <spearce@spearce.org> | 2007-03-07 04:44:37 +0300 |
---|---|---|
committer | Junio C Hamano <junkio@cox.net> | 2007-03-07 22:15:26 +0300 |
commit | dc49cd769b5fa6b7e0114b051c34a849828a7603 (patch) | |
tree | 7eafafcd36ab731599da3fb5e59d3f4379c342d3 /.mailmap | |
parent | 6777a59fcdfd96b9ca5cba49cb265c6c47de3d02 (diff) |
Cast 64 bit off_t to 32 bit size_t
Some systems have sizeof(off_t) == 8 while sizeof(size_t) == 4.
This implies that we are able to access and work on files whose
maximum length is around 2^63-1 bytes, but we can only malloc or
mmap somewhat less than 2^32-1 bytes of memory.
On such a system an implicit conversion of off_t to size_t can cause
the size_t to wrap, resulting in unexpected and exciting behavior.
Right now we are working around all gcc warnings generated by the
-Wshorten-64-to-32 option by passing the off_t through xsize_t().
In the future we should make xsize_t on such problematic platforms
detect the wrapping and die if such a file is accessed.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions