diff options
author | Eric Wong <normalperson@yhbt.net> | 2016-01-14 06:59:48 +0300 |
---|---|---|
committer | Eric Wong <normalperson@yhbt.net> | 2016-03-15 04:35:39 +0300 |
commit | 62335bbbc747c96636b5ce9917b156304c732eaf (patch) | |
tree | 8c1661a75eabad5898349b6f3301cff3e37a724d | |
parent | e4e5dd94e6eea4b50d8baed8b6b8cc50f6c8eae4 (diff) |
git-svn: shorten glob error message
Error messages should attempt to fit within the confines of
an 80-column terminal to avoid compatibility and accessibility
problems. Furthermore the word "directories" can be misleading
when used in the context of git refnames.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
-rw-r--r-- | perl/Git/SVN/GlobSpec.pm | 4 | ||||
-rwxr-xr-x | t/t9108-git-svn-glob.sh | 9 | ||||
-rwxr-xr-x | t/t9109-git-svn-multi-glob.sh | 9 | ||||
-rwxr-xr-x | t/t9168-git-svn-partially-globbed-names.sh | 7 |
4 files changed, 18 insertions, 11 deletions
diff --git a/perl/Git/SVN/GlobSpec.pm b/perl/Git/SVN/GlobSpec.pm index 4775026c5d..a0a8d17621 100644 --- a/perl/Git/SVN/GlobSpec.pm +++ b/perl/Git/SVN/GlobSpec.pm @@ -8,8 +8,8 @@ sub new { $re =~ s!/+$!!g; # no need for trailing slashes my (@left, @right, @patterns); my $state = "left"; - my $die_msg = "Only one set of wildcard directories " . - "(e.g. '*' or '*/*/*') is supported: '$glob'\n"; + my $die_msg = "Only one set of wildcards " . + "(e.g. '*' or '*/*/*') is supported: $glob\n"; for my $part (split(m|/|, $glob)) { if ($pattern_ok && $part =~ /[{}]/ && $part !~ /^\{[^{}]+\}/) { diff --git a/t/t9108-git-svn-glob.sh b/t/t9108-git-svn-glob.sh index a526d60379..a94286c8ec 100755 --- a/t/t9108-git-svn-glob.sh +++ b/t/t9108-git-svn-glob.sh @@ -86,9 +86,12 @@ test_expect_success 'test left-hand-side only globbing' ' test_cmp expect.two output.two ' -echo "Only one set of wildcard directories" \ - "(e.g. '*' or '*/*/*') is supported: 'branches/*/t/*'" > expect.three -echo "" >> expect.three +test_expect_success 'prepare test disallow multi-globs' " +cat >expect.three <<EOF +Only one set of wildcards (e.g. '*' or '*/*/*') is supported: branches/*/t/* + +EOF + " test_expect_success 'test disallow multi-globs' ' git config --add svn-remote.three.url "$svnrepo" && diff --git a/t/t9109-git-svn-multi-glob.sh b/t/t9109-git-svn-multi-glob.sh index f36b749242..8d99e848d4 100755 --- a/t/t9109-git-svn-multi-glob.sh +++ b/t/t9109-git-svn-multi-glob.sh @@ -135,9 +135,12 @@ test_expect_success 'test another branch' ' test_cmp expect.four output.four ' -echo "Only one set of wildcard directories" \ - "(e.g. '*' or '*/*/*') is supported: 'branches/*/t/*'" > expect.three -echo "" >> expect.three +test_expect_success 'prepare test disallow multiple globs' " +cat >expect.three <<EOF +Only one set of wildcards (e.g. '*' or '*/*/*') is supported: branches/*/t/* + +EOF + " test_expect_success 'test disallow multiple globs' ' git config --add svn-remote.three.url "$svnrepo" && diff --git a/t/t9168-git-svn-partially-globbed-names.sh b/t/t9168-git-svn-partially-globbed-names.sh index a7641dc1e9..8b22f2272c 100755 --- a/t/t9168-git-svn-partially-globbed-names.sh +++ b/t/t9168-git-svn-partially-globbed-names.sh @@ -130,9 +130,10 @@ test_expect_success 'test prefixed globs match just prefix' ' ' test_expect_success 'prepare test disallow prefixed multi-globs' " - echo \"Only one set of wildcard directories\" \ - \"(e.g. '*' or '*/*/*') is supported: 'branches/b_*/t/*'\" >expect.four && - echo \"\" >>expect.four +cat >expect.four <<EOF +Only one set of wildcards (e.g. '*' or '*/*/*') is supported: branches/b_*/t/* + +EOF " test_expect_success 'test disallow prefixed multi-globs' ' |