diff options
author | Sergey Vlasov <vsu@altlinux.ru> | 2005-09-21 20:34:29 +0400 |
---|---|---|
committer | Junio C Hamano <junkio@cox.net> | 2005-09-23 08:52:12 +0400 |
commit | 2c08b3638339f9b73128c41a4882e115222608a3 (patch) | |
tree | 68e9a85e461c2bb374d1879cb7de7c5d7dc9cdd1 | |
parent | 24451c31032d4ea3e7750b5f9c61e9c9f1657449 (diff) |
[PATCH] fetch.c: Remove call to parse_object() from process()
The call to parse_object() in process() is not actually needed - if
the object type is unknown, parse_object() will be called by loop();
if the type is known, the object will be parsed by the appropriate
process_*() function.
After this change blobs which exist locally are no longer parsed,
which gives about 2x CPU usage improvement; the downside is that there
will be no warnings for existing corrupted blobs, but detecting such
corruption is the job of git-fsck-objects, not the fetch programs.
Newly fetched objects are still checked for corruption in http-fetch.c
and ssh-fetch.c (local-fetch.c does not seem to do it, but the removed
parse_object() call would not be reached for new objects anyway).
Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Signed-off-by: Junio C Hamano <junkio@cox.net>
-rw-r--r-- | fetch.c | 1 |
1 files changed, 0 insertions, 1 deletions
@@ -134,7 +134,6 @@ static int process(struct object *obj) obj->flags |= SEEN; if (has_sha1_file(obj->sha1)) { - parse_object(obj->sha1); /* We already have it, so we should scan it now. */ obj->flags |= TO_SCAN; } else { |