diff options
author | Carlos Martín Nieto <cmn@elego.de> | 2011-10-15 09:04:26 +0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2011-10-16 09:00:37 +0400 |
commit | e8c1e6c796c1b96b6b208bbd4bc8cfd9acb481b5 (patch) | |
tree | 6de4732d4833f40e31b11dd50097a638fd3c5c90 | |
parent | ed43de6ec35dfd4c4bd33ae9b5f2ebe38282209f (diff) |
fetch: treat --tags like refs/tags/*:refs/tags/* when pruning
If --tags is specified, add that refspec to the list given to
prune_refs so it knows to treat it as a filter on what refs to
should consider for prunning. This way
git fetch --prune --tags origin
only prunes tags and doesn't delete the branch refs.
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | builtin/fetch.c | 23 | ||||
-rwxr-xr-x | t/t5510-fetch.sh | 4 |
2 files changed, 23 insertions, 4 deletions
diff --git a/builtin/fetch.c b/builtin/fetch.c index e295d97fdb..9d481f8ca9 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -735,10 +735,29 @@ static int do_fetch(struct transport *transport, return 1; } if (prune) { - if (ref_count) + /* If --tags was specified, pretend the user gave us the canonical tags refspec */ + if (tags == TAGS_SET) { + const char *tags_str = "refs/tags/*:refs/tags/*"; + struct refspec *tags_refspec, *refspec; + + /* Copy the refspec and add the tags to it */ + refspec = xcalloc(ref_count + 1, sizeof(struct refspec)); + tags_refspec = parse_fetch_refspec(1, &tags_str); + memcpy(refspec, refs, ref_count * sizeof(struct refspec)); + memcpy(&refspec[ref_count], tags_refspec, sizeof(struct refspec)); + ref_count++; + + prune_refs(refspec, ref_count, ref_map); + + ref_count--; + /* The rest of the strings belong to fetch_one */ + free_refspec(1, tags_refspec); + free(refspec); + } else if (ref_count) { prune_refs(refs, ref_count, ref_map); - else + } else { prune_refs(transport->remote->fetch, transport->remote->fetch_refspec_nr, ref_map); + } } free_refs(ref_map); diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh index 581049bf94..e0af4c4e62 100755 --- a/t/t5510-fetch.sh +++ b/t/t5510-fetch.sh @@ -105,7 +105,7 @@ test_expect_success 'fetch --prune with a namespace keeps other namespaces' ' git rev-parse origin/master ' -test_expect_failure 'fetch --prune --tags does not delete the remote-tracking branches' ' +test_expect_success 'fetch --prune --tags does not delete the remote-tracking branches' ' cd "$D" && git clone . prune-tags && cd prune-tags && @@ -116,7 +116,7 @@ test_expect_failure 'fetch --prune --tags does not delete the remote-tracking br test_must_fail git rev-parse somebranch ' -test_expect_failure 'fetch --prune --tags with branch does not delete other remote-tracking branches' ' +test_expect_success 'fetch --prune --tags with branch does not delete other remote-tracking branches' ' cd "$D" && git clone . prune-tags-branch && cd prune-tags-branch && |