diff options
author | Ronnie Sahlberg <sahlberg@google.com> | 2014-06-20 18:42:43 +0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-07-14 22:54:40 +0400 |
commit | 33f9fc593247322ddea5515f548a06cf34d12c2f (patch) | |
tree | 78af5fff143a5c987539b4733ab05a2422fd0f74 | |
parent | 026bd1d3e27a9e9b8f6b0098644c5753a2a1e355 (diff) |
refs.c: ref_transaction_commit should not free the transaction
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Acked-by: Michael Haggerty <mhagger@alum.mit.edu>
-rw-r--r-- | builtin/update-ref.c | 1 | ||||
-rw-r--r-- | refs.c | 1 | ||||
-rw-r--r-- | refs.h | 5 |
3 files changed, 3 insertions, 4 deletions
diff --git a/builtin/update-ref.c b/builtin/update-ref.c index 405267f6e2..1fd7a89186 100644 --- a/builtin/update-ref.c +++ b/builtin/update-ref.c @@ -369,6 +369,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix) update_refs_stdin(); ret = ref_transaction_commit(transaction, msg, UPDATE_REFS_DIE_ON_ERR); + ref_transaction_free(transaction); return ret; } @@ -3509,7 +3509,6 @@ cleanup: if (updates[i]->lock) unlock_ref(updates[i]->lock); free(delnames); - ref_transaction_free(transaction); return ret; } @@ -219,8 +219,7 @@ enum action_on_err { /* * Begin a reference transaction. The reference transaction must - * eventually be commited using ref_transaction_commit() or freed by - * calling ref_transaction_free(). + * be freed by calling ref_transaction_free(). */ struct ref_transaction *ref_transaction_begin(void); @@ -268,7 +267,7 @@ void ref_transaction_delete(struct ref_transaction *transaction, /* * Commit all of the changes that have been queued in transaction, as * atomically as possible. Return a nonzero value if there is a - * problem. The ref_transaction is freed by this function. + * problem. */ int ref_transaction_commit(struct ref_transaction *transaction, const char *msg, enum action_on_err onerr); |