diff options
author | Jeff King <peff@peff.net> | 2015-08-10 12:36:27 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2015-08-11 01:37:13 +0300 |
commit | 07e3070d2aa69b0c8f1da5f103a87125ff4baaea (patch) | |
tree | d58adb8eff1cf700ff4414a4742cfc8a83460866 | |
parent | f5b2dec1657e09a22f8b2aefa25d022988e3e467 (diff) |
path.c: drop git_path_submodule
There are no callers of the slightly-dangerous static-buffer
git_path_submodule left. Let's drop it.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | cache.h | 5 | ||||
-rw-r--r-- | path.c | 10 |
2 files changed, 2 insertions, 13 deletions
@@ -713,12 +713,11 @@ extern int check_repository_format(void); * the repository directory (git_path), or in a submodule's repository * directory (git_path_submodule). In all cases, note that the result * may be overwritten by another call to _any_ of the functions. Consider - * using the safer "dup" or "strbuf" formats below. + * using the safer "dup" or "strbuf" formats below (in some cases, the + * unsafe versions have already been removed). */ extern const char *mkpath(const char *fmt, ...) __attribute__((format (printf, 1, 2))); extern const char *git_path(const char *fmt, ...) __attribute__((format (printf, 1, 2))); -extern const char *git_path_submodule(const char *path, const char *fmt, ...) - __attribute__((format (printf, 2, 3))); extern char *mksnpath(char *buf, size_t n, const char *fmt, ...) __attribute__((format (printf, 3, 4))); @@ -245,16 +245,6 @@ static void do_submodule_path(struct strbuf *buf, const char *path, strbuf_cleanup_path(buf); } -const char *git_path_submodule(const char *path, const char *fmt, ...) -{ - va_list args; - struct strbuf *buf = get_pathname(); - va_start(args, fmt); - do_submodule_path(buf, path, fmt, args); - va_end(args); - return buf->buf; -} - char *git_pathdup_submodule(const char *path, const char *fmt, ...) { va_list args; |