diff options
| author | Junio C Hamano <junkio@cox.net> | 2006-07-10 14:34:34 +0400 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-07-14 10:10:21 +0400 |
| commit | 57a39690b936c003662b6710241732b980e58790 (patch) | |
| tree | 969d9d54900dc423f7ed65854d60dec7d687f9de | |
| parent | 4b7ce6e2d6ba088da50de1df38b040ea2c0b8f18 (diff) | |
fetch/clone: check return status from ls-remote
Some callers of ls-remote did not check its return status.
| -rwxr-xr-x | git-clone.sh | 4 | ||||
| -rwxr-xr-x | git-fetch.sh | 11 |
2 files changed, 11 insertions, 4 deletions
diff --git a/git-clone.sh b/git-clone.sh index 0368803883..a92b22a13d 100755 --- a/git-clone.sh +++ b/git-clone.sh @@ -266,7 +266,7 @@ yes,yes) echo "$repo/objects" >> "$GIT_DIR/objects/info/alternates" ;; esac - git-ls-remote "$repo" >"$GIT_DIR/CLONE_HEAD" + git-ls-remote "$repo" >"$GIT_DIR/CLONE_HEAD" || exit 1 ;; *) case "$repo" in @@ -296,7 +296,7 @@ yes,yes) done rm -f "$GIT_DIR/TMP_ALT" fi - git-ls-remote "$repo" >"$GIT_DIR/CLONE_HEAD" + git-ls-remote "$repo" >"$GIT_DIR/CLONE_HEAD" || exit 1 ;; http://*) if test -z "@@NO_CURL@@" diff --git a/git-fetch.sh b/git-fetch.sh index ff1769952b..0c7a11d565 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -223,9 +223,16 @@ reflist=$(get_remote_refs_for_fetch "$@") if test "$tags" then taglist=`IFS=" " && - git-ls-remote $upload_pack --tags "$remote" | + ( + git-ls-remote $upload_pack --tags "$remote" || + echo fail ouch + ) | while read sha1 name do + case "$sha1" in + fail) + exit 1 + esac case "$name" in *^*) continue ;; esac @@ -235,7 +242,7 @@ then else echo >&2 "warning: tag ${name} ignored" fi - done` + done` || exit if test "$#" -gt 1 then # remote URL plus explicit refspecs; we need to merge them. |