diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2018-02-25 22:46:26 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-02-28 01:52:46 +0300 |
commit | 872ba001f8caaeb496ad79c55fe587a5e31b54f2 (patch) | |
tree | 67654588d00bf6e66061135f69cd8b7bbaabe3aa | |
parent | ca2a4f4a7ee1616b593ee7606139e10c77764006 (diff) |
Git.pm: remove redundant "use strict" from sub-package
In Perl the "use strict/warnings" pragmas are lexical, thus there's no
reason to do:
package Foo;
use strict;
package Bar;
use strict;
$x = 5;
To satisfy the desire that the undeclared $x variable will be spotted
at compile-time. It's enough to include the first "use strict".
This functionally changes nothing, but makes a subsequent change where
"use warnings" will be added to Git.pm less confusing and less
verbose, since as with "strict" we'll only need to do that at the top
of the file.
Changes code initially added in a6065b548f ("Git.pm: Try to support
ActiveState output pipe", 2006-06-25).
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | perl/Git.pm | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/perl/Git.pm b/perl/Git.pm index 9d60d7948b..99e5d943af 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -1692,7 +1692,6 @@ sub DESTROY { # Pipe implementation for ActiveState Perl. package Git::activestate_pipe; -use strict; sub TIEHANDLE { my ($class, @params) = @_; |