diff options
author | Junio C Hamano <gitster@pobox.com> | 2021-04-14 01:28:50 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-04-14 01:28:50 +0300 |
commit | 7b55441db1d122e85dc0e765c626cf5de18ba7a4 (patch) | |
tree | 13d86dd958ebc17d503e8c162ba6fc31f366d9cc | |
parent | 0623669fc6ddc6dc1ad706f135826f9a0910dd4b (diff) | |
parent | b362acf575424bcfea6444ce6cbfe3c3aa3f1192 (diff) |
Merge branch 'ab/perl-do-not-abuse-map'
Perl critique.
* ab/perl-do-not-abuse-map:
git-send-email: replace "map" in void context with "for"
-rwxr-xr-x | git-send-email.perl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/git-send-email.perl b/git-send-email.perl index f5bbf1647e..6893c8e580 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -217,12 +217,12 @@ sub do_edit { $editor = Git::command_oneline('var', 'GIT_EDITOR'); } if (defined($multiedit) && !$multiedit) { - map { + for (@_) { system('sh', '-c', $editor.' "$@"', $editor, $_); if (($? & 127) || ($? >> 8)) { die(__("the editor exited uncleanly, aborting everything")); } - } @_; + } } else { system('sh', '-c', $editor.' "$@"', $editor, @_); if (($? & 127) || ($? >> 8)) { |