diff options
author | Junio C Hamano <gitster@pobox.com> | 2013-08-30 21:05:55 +0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-08-30 21:05:55 +0400 |
commit | e250020cd06b703b5cf618b4f1b2399369c39c9a (patch) | |
tree | cec458d0f4574ce00cc0b66ec3593862c6459c15 | |
parent | e230c568c4b9a991e3175e5f65171a566fd8e39c (diff) | |
parent | 6da8bdcbbfd5ac9c4a92de79d7b4343d5d6bd4c5 (diff) |
Merge branch 'nd/fetch-pack-shallow-fix'
The recent "short-cut clone connectivity check" topic broke a
shallow repository when a fetch operation tries to auto-follow tags.
* nd/fetch-pack-shallow-fix:
fetch-pack: do not remove .git/shallow file when --depth is not specified
-rw-r--r-- | fetch-pack.c | 4 | ||||
-rwxr-xr-x | t/t5500-fetch-pack.sh | 16 |
2 files changed, 19 insertions, 1 deletions
diff --git a/fetch-pack.c b/fetch-pack.c index 6684348c0e..f5d99c1181 100644 --- a/fetch-pack.c +++ b/fetch-pack.c @@ -897,6 +897,8 @@ static struct ref *do_fetch_pack(struct fetch_pack_args *args, packet_flush(fd[1]); if (args->depth > 0) setup_alternate_shallow(); + else + alternate_shallow_file = NULL; if (get_pack(args, fd, pack_lockfile)) die("git fetch-pack: fetch failed."); @@ -987,7 +989,7 @@ struct ref *fetch_pack(struct fetch_pack_args *args, } ref_cpy = do_fetch_pack(args, fd, ref, sought, nr_sought, pack_lockfile); - if (alternate_shallow_file) { + if (args->depth > 0 && alternate_shallow_file) { if (*alternate_shallow_file == '\0') { /* --unshallow */ unlink_or_warn(git_path("shallow")); rollback_lock_file(&shallow_lock); diff --git a/t/t5500-fetch-pack.sh b/t/t5500-fetch-pack.sh index fd2598e601..a80584ea0e 100755 --- a/t/t5500-fetch-pack.sh +++ b/t/t5500-fetch-pack.sh @@ -505,4 +505,20 @@ test_expect_success 'test --all, --depth, and explicit tag' ' ) >out-adt 2>error-adt ' +test_expect_success 'shallow fetch with tags does not break the repository' ' + mkdir repo1 && + ( + cd repo1 && + git init && + test_commit 1 && + test_commit 2 && + test_commit 3 && + mkdir repo2 && + cd repo2 && + git init && + git fetch --depth=2 ../.git master:branch && + git fsck + ) +' + test_done |