diff options
author | Patrick Steinhardt <ps@pks.im> | 2022-12-01 17:45:36 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-12-05 09:14:16 +0300 |
commit | e1e12e97ac73ded85f7d000da1063a774b3cc14f (patch) | |
tree | 66e22e31853435c667234bb0ede40e728203e115 /add-interactive.h | |
parent | 447ac906e189535e77dcb1f4bbe3f1bc917d4c12 (diff) |
attr: fix integer overflow with more than INT_MAX macros
Attributes have a field that tracks the position in the `all_attrs`
array they're stored inside. This field gets set via `hashmap_get_size`
when adding the attribute to the global map of attributes. But while the
field is of type `int`, the value returned by `hashmap_get_size` is an
`unsigned int`. It can thus happen that the value overflows, where we
would now dereference teh `all_attrs` array at an out-of-bounds value.
We do have a sanity check for this overflow via an assert that verifies
the index matches the new hashmap's size. But asserts are not a proper
mechanism to detect against any such overflows as they may not in fact
be compiled into production code.
Fix this by using an `unsigned int` to track the index and convert the
assert to a call `die()`.
Reported-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'add-interactive.h')
0 files changed, 0 insertions, 0 deletions