diff options
author | Martin Ågren <martin.agren@gmail.com> | 2017-10-05 23:32:08 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-10-06 04:07:18 +0300 |
commit | 2954e5ec4361c6932593663859aa437583edb500 (patch) | |
tree | 0227b2bd8e5cb3485574b72377ceaa430048c684 /apply.h | |
parent | 02ae242fdde2ba8acb6b87e32df2b1e33786e78b (diff) |
cache-tree: simplify locking logic
After we have taken the lock using `LOCK_DIE_ON_ERROR`, we know that
`newfd` is non-negative. So when we check for exactly that property
before calling `write_locked_index()`, the outcome is guaranteed.
If we write and commit successfully, we set `newfd = -1`, so that we can
later avoid calling `rollback_lock_file` on an already-committed lock.
But we might just as well unconditionally call `rollback_lock_file()` --
it will be a no-op if we have already committed.
All in all, we use `newfd` as a bool and the only benefit we get from it
is that we can avoid calling a no-op. Remove `newfd` so that we have one
variable less to reason about.
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'apply.h')
0 files changed, 0 insertions, 0 deletions