diff options
| author | Shawn Pearce <spearce@spearce.org> | 2006-09-02 08:16:31 +0400 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-09-02 14:24:37 +0400 |
| commit | 9befac470b4cfad529032dbcffcb71242ec71f91 (patch) | |
| tree | f3715172da747456dd63c6d80c3f1e0a7d6f2d56 /builtin-name-rev.c | |
| parent | ad1ed5ee896ba5d7f89bc04c7441b1532efb9853 (diff) | |
Replace uses of strdup with xstrdup.
Like xmalloc and xrealloc xstrdup dies with a useful message if
the native strdup() implementation returns NULL rather than a
valid pointer.
I just tried to use xstrdup in new code and found it to be missing.
However I expected it to be present as xmalloc and xrealloc are
already commonly used throughout the code.
[jc: removed the part that deals with last_XXX, which I am
finding more and more dubious these days.]
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'builtin-name-rev.c')
| -rw-r--r-- | builtin-name-rev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin-name-rev.c b/builtin-name-rev.c index d44e782c99..52886b69b0 100644 --- a/builtin-name-rev.c +++ b/builtin-name-rev.c @@ -100,7 +100,7 @@ static int name_ref(const char *path, const unsigned char *sha1) else if (!strncmp(path, "refs/", 5)) path = path + 5; - name_rev(commit, strdup(path), 0, 0, deref); + name_rev(commit, xstrdup(path), 0, 0, deref); } return 0; } |