diff options
| author | Stefan Beller <stefanbeller@gmail.com> | 2014-08-11 01:33:26 +0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-08-12 22:00:33 +0400 |
| commit | 81c3ce3cdce8dffb913243f5b2cc09d9fb966e6c (patch) | |
| tree | 974a155e73dec708825519c9f21a44d678bc86ed /builtin/commit.c | |
| parent | 32f56600bb6ac6fc57183e79d2c1515dfa56672f (diff) | |
prepare_revision_walk(): check for return value in all places
Even the documentation tells us:
You should check if it returns any error (non-zero return
code) and if it does not, you can start using get_revision()
to do the iteration.
In preparation for this commit, I grepped all occurrences of
prepare_revision_walk and added error messages, when there were none.
Signed-off-by: Stefan Beller <stefanbeller@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit.c')
| -rw-r--r-- | builtin/commit.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/builtin/commit.c b/builtin/commit.c index 39cf8976e3..447ded63fd 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -989,7 +989,8 @@ static const char *find_author_by_nickname(const char *name) revs.mailmap = &mailmap; read_mailmap(revs.mailmap, NULL); - prepare_revision_walk(&revs); + if (prepare_revision_walk(&revs)) + die(_("revision walk setup failed")); commit = get_revision(&revs); if (commit) { struct pretty_print_context ctx = {0}; |