diff options
author | René Scharfe <l.s.r@web.de> | 2014-08-19 23:09:35 +0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-08-20 20:53:37 +0400 |
commit | d3180279322c7450a47decf8833de47f444ca93f (patch) | |
tree | 6b15045aef08b51a0831ee75bb67fd0beddc0d0c /builtin/repack.c | |
parent | 6c4ab27f2378ce67940b4496365043119d7ffff2 (diff) |
run-command: introduce CHILD_PROCESS_INIT
Most struct child_process variables are cleared using memset first after
declaration. Provide a macro, CHILD_PROCESS_INIT, that can be used to
initialize them statically instead. That's shorter, doesn't require a
function call and is slightly more readable (especially given that we
already have STRBUF_INIT, ARGV_ARRAY_INIT etc.).
Helped-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/repack.c')
-rw-r--r-- | builtin/repack.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/builtin/repack.c b/builtin/repack.c index a77e743b94..fc088dbe6a 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -133,7 +133,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix) {".idx"}, {".bitmap", 1}, }; - struct child_process cmd; + struct child_process cmd = CHILD_PROCESS_INIT; struct string_list_item *item; struct argv_array cmd_args = ARGV_ARRAY_INIT; struct string_list names = STRING_LIST_INIT_DUP; @@ -250,7 +250,6 @@ int cmd_repack(int argc, const char **argv, const char *prefix) argv_array_push(&cmd_args, packtmp); - memset(&cmd, 0, sizeof(cmd)); cmd.argv = cmd_args.argv; cmd.git_cmd = 1; cmd.out = -1; |