diff options
author | Junio C Hamano <gitster@pobox.com> | 2013-10-23 21:52:42 +0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-10-25 01:59:39 +0400 |
commit | af2a651d2ecb3967244c9a44a5813a0cf9977df5 (patch) | |
tree | b2516b618c3bb919a571eded2da72198e1370ed0 /cache.h | |
parent | fd356f6aa8bb75ebef56fbc61caf7e02517fa6d3 (diff) |
checkout_entry(): clarify the use of topath[] parameter
The said function has this signature:
extern int checkout_entry(struct cache_entry *ce,
const struct checkout *state,
char *topath);
At first glance, it might appear that the caller of checkout_entry()
can specify to which path the contents are written out by the last
parameter, and it is tempting to add "const" in front of its type.
In reality, however, topath[] is to point at a buffer to store the
temporary path generated by the callchain originating from this
function, and the temporary path is always short, much shorter than
the buffer prepared by its only caller in builtin/checkout-index.c.
Document the code a bit to clarify so that future callers know how
to use the function better.
Noticed-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'cache.h')
-rw-r--r-- | cache.h | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -975,6 +975,7 @@ struct checkout { refresh_cache:1; }; +#define TEMPORARY_FILENAME_LENGTH 25 extern int checkout_entry(struct cache_entry *ce, const struct checkout *state, char *topath); struct cache_def { |