diff options
author | David Kastrup <dak@gnu.org> | 2007-09-24 00:42:08 +0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2007-09-24 03:12:00 +0400 |
commit | 822f7c7349d61f6075961ce42c1bd1a85cf999e5 (patch) | |
tree | ae3b0243021d42bf07da00b2d47aa4082a68e720 /contrib/examples/git-tag.sh | |
parent | b9fc6ea9efdc988d851666d45d80076839d9c225 (diff) |
Supplant the "while case ... break ;; esac" idiom
A lot of shell scripts contained stuff starting with
while case "$#" in 0) break ;; esac
and similar. I consider breaking out of the condition instead of the
body od the loop ugly, and the implied "true" value of the
non-matching case is not really obvious to humans at first glance. It
happens not to be obvious to some BSD shells, either, but that's
because they are not POSIX-compliant. In most cases, this has been
replaced by a straight condition using "test". "case" has the
advantage of being faster than "test" on vintage shells where "test"
is not a builtin. Since none of them is likely to run the git
scripts, anyway, the added readability should be worth the change.
A few loops have had their termination condition expressed
differently.
Signed-off-by: David Kastrup <dak@gnu.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib/examples/git-tag.sh')
-rwxr-xr-x | contrib/examples/git-tag.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/examples/git-tag.sh b/contrib/examples/git-tag.sh index 5ee3f50a3c..ae7c531666 100755 --- a/contrib/examples/git-tag.sh +++ b/contrib/examples/git-tag.sh @@ -14,7 +14,7 @@ username= list= verify= LINES=0 -while case "$#" in 0) break ;; esac +while test $# != 0 do case "$1" in -a) |