diff options
author | Jeff King <peff@peff.net> | 2020-04-10 22:44:28 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-04-11 00:44:29 +0300 |
commit | f5914f4b6bcdb517733c761fe5ba9d94471eb01d (patch) | |
tree | 12b2a92eecd00075ad0bc04100ebb22d2a0f9e5b /decorate.c | |
parent | 021ba32a7bca954235e31338c4f27b221a1807de (diff) |
parse_config_key(): return subsection len as size_t
We return the length to a subset of a string using an "int *"
out-parameter. This is fine most of the time, as we'd expect config keys
to be relatively short, but it could behave oddly if we had a gigantic
config key. A more appropriate type is size_t.
Let's switch over, which lets our callers use size_t as appropriate
(they are bound by our type because they must pass the out-parameter as
a pointer). This is mostly just a cleanup to make it clear this code
handles long strings correctly. In practice, our config parser already
chokes on long key names (because of a similar int/size_t mixup!).
When doing an int/size_t conversion, we have to be careful that nobody
was trying to assign a negative value to the variable. I manually
confirmed that for each case here. They tend to just feed the result to
xmemdupz() or similar; in a few cases I adjusted the parameter types for
helper functions to make sure the size_t is preserved.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'decorate.c')
0 files changed, 0 insertions, 0 deletions