diff options
author | Junio C Hamano <gitster@pobox.com> | 2008-01-19 10:42:00 +0300 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-01-21 23:44:31 +0300 |
commit | 7fec10b7f41fa32e71aa6377bd04cd7c6fb419e0 (patch) | |
tree | 29820d183e9b379d3aacc4757e4a7ea98c3247a3 /diff.c | |
parent | 7a51ed66f653c248993b3c4a61932e47933d835e (diff) |
index: be careful when handling long names
We currently use lower 12-bit (masked with CE_NAMEMASK) in the
ce_flags field to store the length of the name in cache_entry,
without checking the length parameter given to
create_ce_flags(). This can make us store incorrect length.
Currently we are mostly protected by the fact that many
codepaths first copy the path in a variable of size PATH_MAX,
which typically is 4096 that happens to match the limit, but
that feels like a bug waiting to happen. Besides, that would
not allow us to shorten the width of CE_NAMEMASK to use the bits
for new flags.
This redefines the meaning of the name length stored in the
cache_entry. A name that does not fit is represented by storing
CE_NAMEMASK in the field, and the actual length needs to be
computed by actually counting the bytes in the name[] field.
This way, only the unusually long paths need to suffer.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'diff.c')
0 files changed, 0 insertions, 0 deletions