diff options
author | Luke Diamand <luke@diamand.org> | 2020-01-30 14:50:34 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-01-30 23:21:13 +0300 |
commit | 43f33e492af65d008045ee0695d0f17434e8c3c9 (patch) | |
tree | 50486bc803650cc2374e5d7782505ed0613d33db /git-p4.py | |
parent | 19fa5ac333134fc3aa1e462780c4690177474ade (diff) |
git-p4: avoid leak of file handle when cloning
Spotted by Eric Sunshine:
https://public-inbox.org/git/CAPig+cRx3hG64nuDie69o_gdX39F=sR6D8LyA7J1rCErgu0aMA@mail.gmail.com/
Signed-off-by: Luke Diamand <luke@diamand.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-p4.py')
-rwxr-xr-x | git-p4.py | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -3563,7 +3563,8 @@ class P4Sync(Command, P4UserMap): changes = [] if len(self.changesFile) > 0: - output = open(self.changesFile).readlines() + with open(self.changesFile) as f: + output = f.readlines() changeSet = set() for line in output: changeSet.add(int(line)) |