diff options
author | Jeff King <peff@peff.net> | 2018-08-23 03:50:51 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-08-23 20:08:51 +0300 |
commit | 66e83d9b41f7438cb167b9bb54093ebbf0532437 (patch) | |
tree | e3523c7d6fe3a8e0030357750f3416b487dd588b /line-range.h | |
parent | ffce7f590fabee6f2314ffd891f1fd3629222839 (diff) |
append_signoff: use size_t for string offsets
The append_signoff() function takes an "int" to specify the
number of bytes to ignore. Most callers just pass 0, and the
remainder use ignore_non_trailer() to skip over cruft.
That function also returns an int, and uses them internally.
On systems where size_t is larger than an int (i.e., most
64-bit systems), dealing with a ridiculously large commit
message could end up overflowing an int, producing
surprising results (e.g., returning a negative offset, which
would cause us to look outside the original string).
Let's consistently use size_t for these offsets through this
whole stack. As a bonus, this makes the meaning of
"ignore_footer" as an offset (and not a boolean) more clear.
But while we're here, let's also document the interface.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'line-range.h')
0 files changed, 0 insertions, 0 deletions