diff options
| author | Andy Whitcroft <apw@shadowen.org> | 2007-01-08 18:58:08 +0300 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2007-01-09 02:44:47 +0300 |
| commit | 93d26e4cb9cec2eb8abb4f37e6dda2c86fcceeac (patch) | |
| tree | 8d3cda91ddd8242531995cb304f37578bfaa7cf0 /local-fetch.c | |
| parent | e08140568a131bcd26e64a0bc8188040847be998 (diff) | |
short i/o: fix calls to read to use xread or read_in_full
We have a number of badly checked read() calls. Often we are
expecting read() to read exactly the size we requested or fail, this
fails to handle interrupts or short reads. Add a read_in_full()
providing those semantics. Otherwise we at a minimum need to check
for EINTR and EAGAIN, where this is appropriate use xread().
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'local-fetch.c')
| -rw-r--r-- | local-fetch.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/local-fetch.c b/local-fetch.c index 7b6875cce6..cf99cb72dd 100644 --- a/local-fetch.c +++ b/local-fetch.c @@ -184,7 +184,7 @@ int fetch_ref(char *ref, unsigned char *sha1) fprintf(stderr, "cannot open %s\n", filename); return -1; } - if (read(ifd, hex, 40) != 40 || get_sha1_hex(hex, sha1)) { + if (read_in_full(ifd, hex, 40) != 40 || get_sha1_hex(hex, sha1)) { close(ifd); fprintf(stderr, "cannot read from %s\n", filename); return -1; |