diff options
author | Jeff King <peff@peff.net> | 2014-06-11 01:40:39 +0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-06-13 23:08:17 +0400 |
commit | 152ff1ccebd822fd97f27d2a6c3fa2058f088fd8 (patch) | |
tree | 05c0d7681d2b3e76196d9ee05b94398d62dcf2ec /object.c | |
parent | 66c2827ea4deb24ff541e30a5b6239ad5e9f6801 (diff) |
provide helpers to access the commit buffer
Many sites look at commit->buffer to get more detailed
information than what is in the parsed commit struct.
However, we sometimes drop commit->buffer to save memory,
in which case the caller would need to read the object
afresh. Some callers do this (leading to duplicated code),
and others do not (which opens the possibility of a segfault
if somebody else frees the buffer).
Let's provide a pair of helpers, "get" and "unuse", that let
callers easily get the buffer. They will use the cached
buffer when possible, and otherwise load from disk using
read_sha1_file.
Note that we also need to add a "get_cached" variant which
returns NULL when we do not have a cached buffer. At first
glance this seems to defeat the purpose of "get", which is
to always provide a return value. However, some log code
paths actually use the NULL-ness of commit->buffer as a
boolean flag to decide whether to try printing the
commit. At least for now, we want to continue supporting
that use.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'object.c')
0 files changed, 0 insertions, 0 deletions