diff options
author | Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> | 2020-03-06 22:03:13 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-03-07 01:45:51 +0300 |
commit | 0915a5b4cdf00a8c6c755b77b854725a183993b4 (patch) | |
tree | 9614e0bd72e228432eeb16a1c7219deb0061e3ed /path.c | |
parent | 076cbdcd739aeb33c1be87b73aebae5e43d7bcc5 (diff) |
set_git_dir: fix crash when used with real_path()
`real_path()` returns result from a shared buffer, inviting subtle
reentrance bugs. One of these bugs occur when invoked this way:
set_git_dir(real_path(git_dir))
In this case, `real_path()` has reentrance:
real_path
read_gitfile_gently
repo_set_gitdir
setup_git_env
set_git_dir_1
set_git_dir
Later, `set_git_dir()` uses its now-dead parameter:
!is_absolute_path(path)
Fix this by using a dedicated `strbuf` to hold `strbuf_realpath()`.
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'path.c')
-rw-r--r-- | path.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -850,7 +850,7 @@ const char *enter_repo(const char *path, int strict) } if (is_git_directory(".")) { - set_git_dir("."); + set_git_dir(".", 0); check_repository_format(); return path; } |