diff options
| author | ZheNing Hu <adlternative@gmail.com> | 2022-06-05 16:37:28 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-06-06 20:37:06 +0300 |
| commit | 6d858341d284e08320dc2dbf1952d7a37884e5f3 (patch) | |
| tree | 81136cc0519ccfad66038e36ad96e2c31b406977 /read-cache.c | |
| parent | e54793a95afeea1e10de1e5ad7eab914e7416250 (diff) | |
read-cache.c: reduce unnecessary cache entry name copying
575fa8a3 (read-cache: read data in a hash-independent way,
2019-02-19) added a new code to copy from the on-disk data into the
name member of the in-core cache entry, which is already done
immediately after that in a way that takes prefix-compression into
account.
Remove this code, as it is not just unnecessary, but also can be
reading beyond the on-disk data, when we are copying very long
prefix string from the previous entry.
Signed-off-by: ZheNing Hu <adlternative@gmail.com>
[jc: rewrote the log message with Réne's findings]
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'read-cache.c')
| -rw-r--r-- | read-cache.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/read-cache.c b/read-cache.c index 4df97e185e..02789a63ad 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1944,8 +1944,6 @@ static struct cache_entry *create_from_disk(struct mem_pool *ce_mem_pool, ce->ce_namelen = len; ce->index = 0; oidread(&ce->oid, ondisk->data); - memcpy(ce->name, name, len); - ce->name[len] = '\0'; if (expand_name_field) { if (copy_len) |