diff options
author | René Scharfe <l.s.r@web.de> | 2016-07-30 21:18:31 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2016-08-02 00:01:03 +0300 |
commit | 50492f7b38f84619cbfb443efc3c0c78fc0304dd (patch) | |
tree | 051c7b006815c0c55c8c37039cb9877402b56a1b /refs.c | |
parent | f8f7adce9fc50a11a764d57815602dcb818d1816 (diff) |
pass constants as first argument to st_mult()
The result of st_mult() is the same no matter the order of its
arguments. It invokes the macro unsigned_mult_overflows(), which
divides the second parameter by the first one. Pass constants
first to allow that division to be done already at compile time.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'refs.c')
-rw-r--r-- | refs.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -922,7 +922,7 @@ char *shorten_unambiguous_ref(const char *refname, int strict) /* -2 for strlen("%.*s") - strlen("%s"); +1 for NUL */ total_len += strlen(ref_rev_parse_rules[nr_rules]) - 2 + 1; - scanf_fmts = xmalloc(st_add(st_mult(nr_rules, sizeof(char *)), total_len)); + scanf_fmts = xmalloc(st_add(st_mult(sizeof(char *), nr_rules), total_len)); offset = 0; for (i = 0; i < nr_rules; i++) { |