diff options
author | Ronnie Sahlberg <sahlberg@google.com> | 2014-05-19 21:42:34 +0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-09-03 21:04:08 +0400 |
commit | 93a644ea9d3702cc1cc62c0d413f81f8e46fabe7 (patch) | |
tree | 5a979693e1d3c05ced16fde95b012f6d951e496f /refs.c | |
parent | 8c8bdc0d3582e42c13815a191344b1aa3e06c792 (diff) |
refs.c: make ref_transaction_begin take an err argument
Add an err argument to _begin so that on non-fatal failures in future ref
backends we can report a nice error back to the caller.
While _begin can currently never fail for other reasons than OOM, in which
case we die() anyway, we may add other types of backends in the future.
For example, a hypothetical MySQL backend could fail in _begin with
"Can not connect to MySQL server. No route to host".
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'refs.c')
-rw-r--r-- | refs.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -3397,7 +3397,7 @@ struct ref_transaction { size_t nr; }; -struct ref_transaction *ref_transaction_begin(void) +struct ref_transaction *ref_transaction_begin(struct strbuf *err) { return xcalloc(1, sizeof(struct ref_transaction)); } |