diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2022-08-02 18:33:15 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-08-03 21:01:03 +0300 |
commit | 57efebb9b96847adcd25bab0d2c21c599b8f1954 (patch) | |
tree | e580bff2f05443efd62483811742e3abdd21d6a9 /remote.c | |
parent | f89d085b3f6c4861265baed212c8ff6b7a8ec8e6 (diff) |
bisect.c: partially fix bisect_rev_setup() memory leak
Partially fix the memory leak noted in in 8a534b61241 (bisect: use
argv_array API, 2011-09-13), which added the "XXX" comment seen in the
context. We can partially fix it by having the bisect_rev_setup()
function take a "struct strvec", rather than constructing it.
As the comment notes we need to keep the construct "rev_argv" around
while the "struct rev_info" is around, which as seen in the newly
added "strvec_clear()" calls here we do after "release_revisions()".
This "partially" fixes the memory leak because we're leaking the "--"
added to the "rev_argv" here still, which will be addressed in a
subsequent commit.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'remote.c')
0 files changed, 0 insertions, 0 deletions