diff options
| author | Derrick Stolee <dstolee@microsoft.com> | 2018-04-06 22:09:38 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-04-11 04:47:16 +0300 |
| commit | 2e27bd7731d47b374c1c14b53af07b3bfa39fcac (patch) | |
| tree | c7635d69f1c20bfb0d3a61feebcedca13d9161ad /revision.c | |
| parent | 5bb03de102b40d9e564be3a3a39084a550db79cb (diff) | |
treewide: replace maybe_tree with accessor methods
In anticipation of making trees load lazily, create a Coccinelle
script (contrib/coccinelle/commit.cocci) to ensure that all
references to the 'maybe_tree' member of struct commit are either
mutations or accesses through get_commit_tree() or
get_commit_tree_oid().
Apply the Coccinelle script to create the rest of the patch.
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.c')
| -rw-r--r-- | revision.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/revision.c b/revision.c index f61d1c9307..d64d2a859e 100644 --- a/revision.c +++ b/revision.c @@ -439,8 +439,8 @@ static void file_change(struct diff_options *options, static int rev_compare_tree(struct rev_info *revs, struct commit *parent, struct commit *commit) { - struct tree *t1 = parent->maybe_tree; - struct tree *t2 = commit->maybe_tree; + struct tree *t1 = get_commit_tree(parent); + struct tree *t2 = get_commit_tree(commit); if (!t1) return REV_TREE_NEW; @@ -476,7 +476,7 @@ static int rev_compare_tree(struct rev_info *revs, static int rev_same_tree_as_empty(struct rev_info *revs, struct commit *commit) { int retval; - struct tree *t1 = commit->maybe_tree; + struct tree *t1 = get_commit_tree(commit); if (!t1) return 0; @@ -614,7 +614,7 @@ static void try_to_simplify_commit(struct rev_info *revs, struct commit *commit) if (!revs->prune) return; - if (!commit->maybe_tree) + if (!get_commit_tree(commit)) return; if (!commit->parents) { |