diff options
author | Jeff King <peff@peff.net> | 2016-02-12 01:23:48 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2016-02-12 23:51:05 +0300 |
commit | 415959387e0642842be7aad05fa5d95ea4ed350f (patch) | |
tree | 240421bf676f922585f4f959e845c3ce1eb00bea /revision.h | |
parent | 494398473714dcbedb38b1ac79b531c7384b3bc4 (diff) |
http-push: stop using name_path
The graph traversal code here passes along a name_path to
build up the pathname at which we find each blob. But we
never actually do anything with the resulting names, making
it a waste of code and memory.
This usage came in aa1dbc9 (Update http-push functionality,
2006-03-07), and originally the result was passed to
"add_object" (which stored it, but didn't really use it,
either). But we stopped using that function in 1f1e895 (Add
"named object array" concept, 2006-06-19) in favor of
storing just the objects themselves.
Moreover, the generation of the name in process_tree() is
buggy. It sticks "name" onto the end of the name_path linked
list, and then passes it down again as it recurses (instead
of "entry.path"). So it's a good thing this was unused, as
the resulting path for "a/b/c/d" would end up as "a/a/a/a".
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.h')
0 files changed, 0 insertions, 0 deletions