diff options
| author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | 2018-03-23 20:45:27 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-03-26 20:07:43 +0300 |
| commit | 464416a2eaadf84d2bfdf795007863d03b222b7c (patch) | |
| tree | d6171bac0e528aad6224c78e20e647a487e236a3 /sha1_name.c | |
| parent | 0a0dd632aa9c9bcdb1b79a7fc4cf6dc161760020 (diff) | |
packfile: keep prepare_packed_git() private
The reason callers have to call this is to make sure either packed_git
or packed_git_mru pointers are initialized since we don't do that by
default. Sometimes it's hard to see this connection between where the
function is called and where packed_git pointer is used (sometimes in
separate functions).
Keep this dependency internal because now all access to packed_git and
packed_git_mru must go through get_xxx() wrappers.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'sha1_name.c')
| -rw-r--r-- | sha1_name.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sha1_name.c b/sha1_name.c index e0b62f3c56..31c013ac7e 100644 --- a/sha1_name.c +++ b/sha1_name.c @@ -196,7 +196,6 @@ static void find_short_packed_object(struct disambiguate_state *ds) { struct packed_git *p; - prepare_packed_git(the_repository); for (p = get_packed_git(the_repository); p && !ds->ambiguous; p = p->next) unique_in_pack(p, ds); @@ -567,7 +566,6 @@ static void find_abbrev_len_packed(struct min_abbrev_data *mad) { struct packed_git *p; - prepare_packed_git(the_repository); for (p = get_packed_git(the_repository); p; p = p->next) find_abbrev_len_for_pack(p, mad); } |