diff options
author | Jeff King <peff@peff.net> | 2014-06-18 23:47:50 +0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-06-20 21:44:45 +0400 |
commit | ae021d87911da4328157273df24779892cb51277 (patch) | |
tree | aede96cb37d98c5675cd3f31322d4fb50f14d6e9 /sha1_name.c | |
parent | 21a2d4ada52132e6b0b67f8e28aa4bcda416f7f2 (diff) |
use skip_prefix to avoid magic numbers
It's a common idiom to match a prefix and then skip past it
with a magic number, like:
if (starts_with(foo, "bar"))
foo += 3;
This is easy to get wrong, since you have to count the
prefix string yourself, and there's no compiler check if the
string changes. We can use skip_prefix to avoid the magic
numbers here.
Note that some of these conversions could be much shorter.
For example:
if (starts_with(arg, "--foo=")) {
bar = arg + 6;
continue;
}
could become:
if (skip_prefix(arg, "--foo=", &bar))
continue;
However, I have left it as:
if (skip_prefix(arg, "--foo=", &v)) {
bar = v;
continue;
}
to visually match nearby cases which need to actually
process the string. Like:
if (skip_prefix(arg, "--foo=", &v)) {
bar = atoi(v);
continue;
}
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'sha1_name.c')
0 files changed, 0 insertions, 0 deletions