diff options
author | Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> | 2020-03-10 16:11:24 +0300 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-03-10 21:41:40 +0300 |
commit | 49d3c4b481f12c2ec655a71d5a5b9259a398d059 (patch) | |
tree | a678f157d48912fff898af8044b98b9a3f004714 /submodule.c | |
parent | 4530a85b4c34f009b5f190eb2dc8367801de5028 (diff) |
get_superproject_working_tree(): return strbuf
Together with the previous commits, this commit fully fixes the problem
of using shared buffer for `real_path()` in `get_superproject_working_tree()`.
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'submodule.c')
-rw-r--r-- | submodule.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/submodule.c b/submodule.c index 215c62580f..c3aadf3fff 100644 --- a/submodule.c +++ b/submodule.c @@ -2168,14 +2168,13 @@ void absorb_git_dir_into_superproject(const char *path, } } -const char *get_superproject_working_tree(void) +int get_superproject_working_tree(struct strbuf *buf) { - static struct strbuf realpath = STRBUF_INIT; struct child_process cp = CHILD_PROCESS_INIT; struct strbuf sb = STRBUF_INIT; struct strbuf one_up = STRBUF_INIT; const char *cwd = xgetcwd(); - const char *ret = NULL; + int ret = 0; const char *subpath; int code; ssize_t len; @@ -2186,10 +2185,10 @@ const char *get_superproject_working_tree(void) * We might have a superproject, but it is harder * to determine. */ - return NULL; + return 0; if (!strbuf_realpath(&one_up, "../", 0)) - return NULL; + return 0; subpath = relative_path(cwd, one_up.buf, &sb); strbuf_release(&one_up); @@ -2233,8 +2232,8 @@ const char *get_superproject_working_tree(void) super_wt = xstrdup(cwd); super_wt[cwd_len - super_sub_len] = '\0'; - strbuf_realpath(&realpath, super_wt, 1); - ret = realpath.buf; + strbuf_realpath(buf, super_wt, 1); + ret = 1; free(super_wt); } strbuf_release(&sb); @@ -2243,10 +2242,10 @@ const char *get_superproject_working_tree(void) if (code == 128) /* '../' is not a git repository */ - return NULL; + return 0; if (code == 0 && len == 0) /* There is an unrelated git repository at '../' */ - return NULL; + return 0; if (code) die(_("ls-tree returned unexpected return code %d"), code); |