diff options
author | Junio C Hamano <gitster@pobox.com> | 2008-05-24 09:28:56 +0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2008-05-24 11:01:56 +0400 |
commit | 3af828634fa5bdbca1b2061a81df8b3fa73b0d34 (patch) | |
tree | f4d4a50e8c1686b3ecd796a09f98cc6ca13bc907 /t/t5400-send-pack.sh | |
parent | 998b912927281a871e8d379e2b3a4385c775c4fe (diff) |
tests: do not use implicit "git diff --no-index"
As a general principle, we should not use "git diff" to validate the
results of what git command that is being tested has done. We would not
know if we are testing the command in question, or locating a bug in the
cute hack of "git diff --no-index".
Rather use test_cmp for that purpose.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5400-send-pack.sh')
-rwxr-xr-x | t/t5400-send-pack.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh index 2b6b6e3f71..68c2ae688c 100755 --- a/t/t5400-send-pack.sh +++ b/t/t5400-send-pack.sh @@ -110,7 +110,7 @@ test_expect_success \ cd .. && git update-ref refs/heads/master master^ || return 1 git-send-pack --force ./victim/.git/ master && return 1 - ! git diff .git/refs/heads/master victim/.git/refs/heads/master + ! test_cmp .git/refs/heads/master victim/.git/refs/heads/master ' test_expect_success \ |