diff options
| author | Junio C Hamano <gitster@pobox.com> | 2010-12-03 23:28:00 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-12-03 23:28:00 +0300 |
| commit | 491e359c949ef7b7ed3fd24ba59f1b7e4cc17e87 (patch) | |
| tree | 7c5820e430274ccae2cc54aea5557f57cd747d16 /t/t9300-fast-import.sh | |
| parent | 777f80d7429b0f2687cb9ff40f82b196b78384ff (diff) | |
t9300: remove unnecessary use of /dev/stdin
We really shouldn't be using these funny /dev/* files that did not exist
in V7 UNIX in our tests when we do not have to.
Output from
$ git grep -n -e /dev/ --and --not -e /dev/null t/
tells us that, aside from use of /dev/urandom in apache.conf used in http
tests, "dd if=/dev/stdin" added recently to t/t9300-fast-import.sh are the
only offenders, and "dd" reads from the standard input by default, so
removing them should be straightforward.
Reported-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9300-fast-import.sh')
| -rwxr-xr-x | t/t9300-fast-import.sh | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh index d615d04a32..055ddc6ddc 100755 --- a/t/t9300-fast-import.sh +++ b/t/t9300-fast-import.sh @@ -1794,7 +1794,7 @@ test_expect_success PIPE 'R: copy using cat-file' ' read blob_id type size <&3 && echo "$blob_id $type $size" >response && - dd if=/dev/stdin of=blob bs=$size count=1 <&3 && + dd of=blob bs=$size count=1 <&3 && read newline <&3 && cat <<EOF && @@ -1845,7 +1845,7 @@ test_expect_success PIPE 'R: print blob mid-commit' ' EOF read blob_id type size <&3 && - dd if=/dev/stdin of=actual bs=$size count=1 <&3 && + dd of=actual bs=$size count=1 <&3 && read newline <&3 && echo @@ -1880,7 +1880,7 @@ test_expect_success PIPE 'R: print staged blob within commit' ' echo "cat-blob $to_get" && read blob_id type size <&3 && - dd if=/dev/stdin of=actual bs=$size count=1 <&3 && + dd of=actual bs=$size count=1 <&3 && read newline <&3 && echo deleteall |