diff options
| author | Junio C Hamano <gitster@pobox.com> | 2017-09-10 11:08:22 +0300 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-09-10 11:08:22 +0300 |
| commit | a48ce378585054f2ae3b2f0e18346ab005290524 (patch) | |
| tree | bfb2fab6ffc87128bd4cbc03ff40a83ce07f8001 /transport-helper.c | |
| parent | 3ec7d702a89c647ddf42a59bc3539361367de9d5 (diff) | |
| parent | 6cdf8a7929688ea5702ab53f450d038e973e64e1 (diff) | |
Merge branch 'ma/ts-cleanups'
Assorted bugfixes and clean-ups.
* ma/ts-cleanups:
ThreadSanitizer: add suppressions
strbuf_setlen: don't write to strbuf_slopbuf
pack-objects: take lock before accessing `remaining`
convert: always initialize attr_action in convert_attrs
Diffstat (limited to 'transport-helper.c')
| -rw-r--r-- | transport-helper.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/transport-helper.c b/transport-helper.c index 8f68d69a86..f50b34df2d 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -1117,6 +1117,13 @@ int transport_helper_init(struct transport *transport, const char *name) __attribute__((format (printf, 1, 2))) static void transfer_debug(const char *fmt, ...) { + /* + * NEEDSWORK: This function is sometimes used from multiple threads, and + * we end up using debug_enabled racily. That "should not matter" since + * we always write the same value, but it's still wrong. This function + * is listed in .tsan-suppressions for the time being. + */ + va_list args; char msgbuf[PBUFFERSIZE]; static int debug_enabled = -1; |