From 6dfadc8981a3f2fd3fb552eb956fe12a542f8ee8 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Sat, 30 Apr 2022 22:17:15 -0700 Subject: clone: plug a miniscule leak The remote_name variable is first assigned a copy of the value of the "clone.defaultremotename" configuration variable and then by the value of the "--origin" command line option. The former is prepared to see multiple instances of the configuration variable by freeing the current value of the variable before a copy of the newly discovered value gets assigned to it. The latter however blindly assigned a copy of the new value to the variable, thereby leaking the value read from the configuration variable. Signed-off-by: Junio C Hamano --- builtin/clone.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/builtin/clone.c b/builtin/clone.c index 5231656379..194d50f75f 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -1106,8 +1106,10 @@ int cmd_clone(int argc, const char **argv, const char *prefix) * apply the remote name provided by --origin only after this second * call to git_config, to ensure it overrides all config-based values. */ - if (option_origin != NULL) + if (option_origin != NULL) { + free(remote_name); remote_name = xstrdup(option_origin); + } if (remote_name == NULL) remote_name = xstrdup("origin"); -- cgit v1.2.3